Fix uninitialized variables reported by Coverity

OpenSCAP · Sep 20, 2023 · 1148277 · 1148277
1 parent 73d957d
commit 1148277
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/src/OVAL/oval_component.c b/src/OVAL/oval_component.c
@@ -2287,6 +2287,8 @@ static oval_syschar_collection_flag_t _oval_component_evaluate_ARITHMETIC_rec(st
 		struct oval_value *ov;
 		char sv[32];
 
+		memset(sv, 0, sizeof (sv));
+
 		if (datatype == OVAL_DATATYPE_INTEGER) {
 			snprintf(sv, sizeof (sv), "%ld", (long int) val);
 		} else if (datatype == OVAL_DATATYPE_FLOAT) {

diff --git a/src/OVAL/probes/SEAP/seap.c b/src/OVAL/probes/SEAP/seap.c
@@ -526,6 +526,7 @@ int SEAP_replyerr (SEAP_CTX_t *ctx, int sd, SEAP_msg_t *rep_msg, uint32_t e)
         _A(ctx != NULL);
         _A(rep_msg != NULL);
 
+        err.type = 0;
         err.code = e;
         err.id   = rep_msg->id;
         err.data = NULL; /* FIXME: Attach original message */

diff --git a/src/OVAL/probes/probe/icache.c b/src/OVAL/probes/probe/icache.c
@@ -500,6 +500,9 @@ static int probe_cobj_memcheck(size_t item_cnt, double max_ratio)
 		struct sys_memusage  mu_sys;
 		double c_ratio;
 
+		memset(&mu_proc, 0, sizeof(mu_proc));
+		memset(&mu_sys, 0, sizeof(mu_sys));
+
 		if (oscap_proc_memusage (&mu_proc) != 0)
 			return (-1);
 

diff --git a/src/OVAL/probes/unix/xinetd_probe.c b/src/OVAL/probes/unix/xinetd_probe.c
@@ -746,9 +746,9 @@ xiconf_t *xiconf_parse(const char *path, unsigned int max_depth)
 
 				switch (inctype) {
 				case XICONF_INCTYPE_FILE:
-					dD("includefile: %s", pathbuf);
+					dD("includefile: %s", inclarg);
 
-					if (xiconf_add_cfile (xiconf, pathbuf, xifile->depth + 1) != 0) {
+					if (xiconf_add_cfile (xiconf, inclarg, xifile->depth + 1) != 0) {
 						tmpbuf_free(buffer);
 						continue;
 					}