-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: add default CH code when not provided during open data import #10236
base: dev
Are you sure you want to change the base?
Conversation
Signed-off-by: SarahBellaha <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10236 +/- ##
==========================================
- Coverage 81.44% 81.39% -0.05%
==========================================
Files 1058 1040 -18
Lines 104268 103481 -787
Branches 722 722
==========================================
- Hits 84916 84224 -692
+ Misses 19311 19216 -95
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
try { | ||
const payloadSteps = { | ||
object: 'operationalpoint', | ||
query: ['and', stepsQuery, mainChCodeConstraint], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also need to filter by infra ID here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we retrieve information from the OP with its UIC code, which is normally unique regardless of the infra (thanks to the "country code"), i don't think it's necessary here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A test infra created by a random person might have a BV CH which doesn't really exist in the real infra the user is interested in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I'm not a fan of looking at the infrastructure during the import step. Right now the import is completely disconnected from the infrastructure (much like etl-basic) and that's a very good property IMHO.
FWIW, when the CH is unspecified in a path step, the backend is supposed to automatically pick BV/00. |
Closes #10159