-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter TowedRollingStocks to include only allowed values #10227
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10227 +/- ##
==========================================
+ Coverage 81.42% 81.47% +0.04%
==========================================
Files 1057 1058 +1
Lines 104204 104297 +93
Branches 720 722 +2
==========================================
+ Hits 84849 84971 +122
+ Misses 19313 19285 -28
+ Partials 42 41 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
front/src/modules/towedRollingStock/hooks/useFilterTowedRollingStock.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, tested.
Agree with @SharglutDev comments
front/src/applications/stdcm/components/StdcmForm/StdcmConsist.tsx
Outdated
Show resolved
Hide resolved
ae9c16a
to
5240600
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested
…lues Signed-off-by: Achraf Mohyeddine <[email protected]>
5240600
to
20f206f
Compare
Closes #10120