Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter TowedRollingStocks to include only allowed values #10227

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

achrafmohye
Copy link
Contributor

Closes #10120

@achrafmohye achrafmohye requested a review from a team as a code owner January 3, 2025 09:31
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 3, 2025
@achrafmohye achrafmohye changed the title filter TowedRollingStocks to include only allowed values Filter TowedRollingStocks to include only allowed values Jan 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.47%. Comparing base (2d1a142) to head (20f206f).
Report is 55 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10227      +/-   ##
==========================================
+ Coverage   81.42%   81.47%   +0.04%     
==========================================
  Files        1057     1058       +1     
  Lines      104204   104297      +93     
  Branches      720      722       +2     
==========================================
+ Hits        84849    84971     +122     
+ Misses      19313    19285      -28     
+ Partials       42       41       -1     
Flag Coverage Δ
editoast 73.65% <ø> (+0.07%) ⬆️
front 89.21% <100.00%> (+0.03%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, tested.
Agree with @SharglutDev comments

@achrafmohye achrafmohye force-pushed the ame/filter-allowed-towed-rolling-stocks branch from ae9c16a to 5240600 Compare January 8, 2025 08:51
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

@achrafmohye achrafmohye force-pushed the ame/filter-allowed-towed-rolling-stocks branch from 5240600 to 20f206f Compare January 8, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stdcm: front: filter towed rolling stocks to keep freight ones
5 participants