Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ロードするモジュールのパスに環境変数を設定可能にする #1010

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Nobu19800
Copy link

Identify the Bug

manager.modules.load_pathmanager.preload.modulesmanager.modules.<lang>.load_pathslogger.pluginsで設定したモジュールを絶対パスで設定した場合、他の環境に移植する場合にパスが変わるため修正の必要がある。

Description of the Change

manager.modules.load_pathmanager.preload.modulesmanager.modules.<lang>.load_pathslogger.pluginsに以下のように環境変数を設定できるようにした。

manager.modules.load_path: ${RTM_ROOT}/ext/${RTM_VC_VERSION}/http

この例ではWindowsインストーラーでRTM_ROOTRTM_VC_VERSIONが設定されるため、他の環境でも同じモジュールをロードできる。

Verification

  • Did you succeed the build?
  • No warnings for the build?
  • Have you passed the unit tests?

n-ando
n-ando previously approved these changes Jan 24, 2022
@n-kawauchi n-kawauchi marked this pull request as ready for review August 30, 2024 09:02
Copy link

@n-kawauchi n-kawauchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最新masterへマージしたところコンフリクトしました。

>git merge feature/config_replace_env
Auto-merging src/lib/rtm/ModuleManager.cpp
CONFLICT (content): Merge conflict in src/lib/rtm/ModuleManager.cpp
Automatic merge failed; fix conflicts and then commit the result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants