Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pl-PL: Fix and improve #2976

Merged
merged 2 commits into from
Dec 6, 2024
Merged

pl-PL: Fix and improve #2976

merged 2 commits into from
Dec 6, 2024

Conversation

arekdurlik
Copy link
Contributor

Found some more things to fix. I think the objects file can be left alone for now, at least until the new Wooden Twister is added.

pl-PL.json:

  • almost all rollercoasters that had just the word "kolejka" in their name, started with that word, except for three, so I adjusted them for consistency,
  • changed the RCT1 Corkscrew name and description to be the same as RCT2,
  • capitalized pronouns,
  • better name for Dynamite Dunes,
  • smaller fixes.

pl-PL.txt:

  • mostly small fixes and improved consistency.

Copy link

github-actions bot commented Dec 6, 2024

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

pl-PL 2 0 96

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

ar-EG 184 1 1765
ca-ES 2 0 86
cs-CZ 188 0 140
da-DK 2 0 245
de-DE 4 0 141
en-US 3405 0 1
eo-ZZ 2 0 65
es-ES 37 0 159
fi-FI 4 0 96
fr-CA 3561 0 0
fr-FR 53 0 134
gl-ES 4 2 97
hu-HU 4 0 86
it-IT 2 0 133
ja-JP 4 0 121
ko-KR 2 0 89
nb-NO 93 0 163
nl-NL 2 0 175
pt-BR 2 0 133
ru-RU 1107 0 65
sv-SE 58 0 150
tr-TR 422 0 98
uk-UA 88 33 725
vi-VN 284 2 2788
zh-CN 68 0 30
zh-TW 179 0 105

1 similar comment
Copy link

github-actions bot commented Dec 6, 2024

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

pl-PL 2 0 96

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

ar-EG 184 1 1765
ca-ES 2 0 86
cs-CZ 188 0 140
da-DK 2 0 245
de-DE 4 0 141
en-US 3405 0 1
eo-ZZ 2 0 65
es-ES 37 0 159
fi-FI 4 0 96
fr-CA 3561 0 0
fr-FR 53 0 134
gl-ES 4 2 97
hu-HU 4 0 86
it-IT 2 0 133
ja-JP 4 0 121
ko-KR 2 0 89
nb-NO 93 0 163
nl-NL 2 0 175
pt-BR 2 0 133
ru-RU 1107 0 65
sv-SE 58 0 150
tr-TR 422 0 98
uk-UA 88 33 725
vi-VN 284 2 2788
zh-CN 68 0 30
zh-TW 179 0 105

@Gymnasiast Gymnasiast merged commit 912af0f into OpenRCT2:master Dec 6, 2024
1 check passed
@Gymnasiast
Copy link
Member

I have just re-dumped the translation, so you can modify the Classic Wooden Twister if desired.

@arekdurlik
Copy link
Contributor Author

Looks good, no need to change. Just the .txt strings left to translate, but I wanted to wait for an issue as to not make a mess.

@Gymnasiast
Copy link
Member

What do you mean exactly by the .txt changes?

@arekdurlik
Copy link
Contributor Author

The strings STR_0099 and STR_0609. I noticed they were added, but wanted to wait for an issue before adding them to pl-PL.txt

@Gymnasiast
Copy link
Member

I completely forgot about that. Created an issue here: #2977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants