Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

de-DE: fix a typo and improve formatting consistency #2700

Merged
merged 1 commit into from
Jan 6, 2024
Merged

de-DE: fix a typo and improve formatting consistency #2700

merged 1 commit into from
Jan 6, 2024

Conversation

Sadret
Copy link
Contributor

@Sadret Sadret commented Jan 6, 2024

  • changed "rauh" to "rau", which is the correct spelling since 1996
  • removed the full stop at the end of some sentences, where there is no full stop in similar sentences

- changed "rauh" to "rau", which is the correct spelling since 1996
- removed the full stop at the end of some sentences, where there is no full stop in similar sentences
Copy link

github-actions bot commented Jan 6, 2024

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

de-DE 2 1 352

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

ar-EG 75 2 1956
ca-ES 4 1 117
cs-CZ 384 0 246
da-DK 122 1 484
en-US 3380 0 390
eo-ZZ 0 1 89
es-ES 2 1 304
fi-FI 157 1 109
fr-CA 3963 0 0
fr-FR 4 1 160
hu-HU 114 1 116
it-IT 3 1 342
ja-JP 300 1 608
ko-KR 0 1 194
nb-NO 310 0 2165
nl-NL 0 13 451
pl-PL 142 1 380
pt-BR 0 1 146
ru-RU 1306 0 111
sv-SE 164 1 341
tr-TR 363 1 395
vi-VN 222 3 3260
zh-CN 4 1 82
zh-TW 117 0 332

@Gymnasiast
Copy link
Member

@Sadret In the Dutch translation, I used a full stop at the end of every description as I considered that more in line with how Dutch is written.

I don’t know if that also applies to German - I’ll leave that to you.

@Sadret
Copy link
Contributor Author

Sadret commented Jan 6, 2024

Right now, there are three ride description with and all the others without. I just wanted to make that consistent, without questioning which one makes more sense.

In my opinion, we should have full stops there, too. But I also do not see it as very important. Also, some of the descriptions are not sentences in the grammatical sense:
"A compact roller coaster with individual cars and smooth twisting drops"
"Eine kompakte Achterbahn mit unabhängigen Wagen und gemäßigten, sich windenden Gefällen"

@Gymnasiast Gymnasiast merged commit 95d0c00 into OpenRCT2:master Jan 6, 2024
1 check passed
@Sadret Sadret deleted the Sadret-patch-1 branch January 6, 2024 12:04
@Gymnasiast
Copy link
Member

@Sadret Feel free to modify these. The German translation has no maintainer at the moment and improvements are always welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants