Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug introduced by refactor. Sulley would indicate that a target failed to restart, even when it didn't.
Session.restart_target
is used (bypoll_pedrpc
) as if it returns True or False. It actually returned None or False.In
master
,sulley/sessions.py
line 705 revision 54bdbbeIn
sulley_refactor
,sulley/sessions.py
line 673 revision 256c21dThe problem is that restart_target never returned True if it succeeded. It returned None. This worked before, since
None == False
is False. Butnot None
is True. I updatedrestart_target
to return True if it succeeds.