backend/ipp.c: Fix printing jobs with long names on older IPP printers #866
Conversation
|
@michaelrsweet hmm, good point! Should we transcode it via |
No, but we might want to implement a "smart" snprintf that can safely truncate UTF-8 at some point... |
On older printers (ones which don't support IPP operation Create-Job) we concatenate job number and title into one string, which we use as IPP attribute job-name. If the original title was almost 255 chars, the joining the strings will overflow maximal required length for this attribute, and Validate-Job fails. We could check whether the string is longer than 255 and cut it, but I chose to shrink the buffer to 256, since we already use snprintf() which will cut the string and put null terminator for us. Fixes OpenPrinting#644
zdohnal
force-pushed
the
job-namem-too-long
branch
from
e1f079a to
d959811
Compare
|
@michaelrsweet I've added a note about UTF-8, so we know there might be problem in the future. |
|
@zdohnal In the end the generic root of this evil is that |
|
@jsmeix looks interesting :) but at least we can do our best effort when we can :D |
On older printers (ones which don't support IPP operation Create-Job) we concatenate job number and title into one string, which we use as IPP attribute job-name. If the original title was almost 255 chars, the joining the strings will overflow maximal required length for this attribute, and Validate-Job fails.
We could check whether the string is longer than 255 and cut it, but I chose to shrink the buffer to 256, since we already use
snprintf()which will cut the string and put null terminator for us.Fixes #644