scheduler/colorman.c: Fix memory leak during creating color profile #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the array `profiles` is set to use `strdup()` as a copy function, we don't have to use `strdup()` on the element which is passed as parameter of `cupsArrayAdd()` - using the `strdup()` as we used till now causes memory leak. Reproducer is the same as OpenPrinting#813 .
zdohnal
added a commit
to zdohnal/cups
that referenced
this pull request
Nov 27, 2023
The string which we add into array stays `const` after fixing OpenPrinting#814 (because `strdup()`, which caused memory leak returned `char *`) and compiler fails because of it if it runs with '-Werror -Wall'.
zdohnal
added a commit
to zdohnal/cups
that referenced
this pull request
Nov 27, 2023
The string which we add into array stays `const` after fixing OpenPrinting#814 (because `strdup()`, which caused memory leak returned `char *`) and compiler fails because of it if it runs with '-Werror -Wall'.
zdohnal
added a commit
to zdohnal/cups
that referenced
this pull request
Nov 27, 2023
The string which we add into array stays `const` after fixing OpenPrinting#814 (because `strdup()`, which caused memory leak returned `char *`) and compiler fails because of it if it runs with '-Werror -Wall'.
zdohnal
added a commit
to zdohnal/cups
that referenced
this pull request
Nov 27, 2023
The string which we add into array stays `const` after fixing OpenPrinting#814 (because `strdup()`, which caused memory leak returned `char *`) and compiler fails because of it if it runs with '-Werror -Wall'.
zdohnal
added a commit
to zdohnal/cups
that referenced
this pull request
Nov 27, 2023
The string which we add into array stays `const` after fixing OpenPrinting#814 (because `strdup()`, which caused memory leak returned `char *`) and compiler fails because of it if it runs with '-Werror -Wall'.
zdohnal
added a commit
that referenced
this pull request
Nov 29, 2023
The string which we add into array stays const after fixing #814 (because strdup(), which caused memory leak returned char *) and compiler fails because of it if it runs with '-Werror -Wall'.
zdohnal
added a commit
that referenced
this pull request
Nov 29, 2023
The string which we add into array stays `const` after fixing #814 (because `strdup()`, which caused memory leak returned `char *`) and compiler fails because of it if it runs with '-Werror -Wall'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the array
profilesis set to usestrdup()as a copy function, we don't have to usestrdup()on the element which is passed as parameter ofcupsArrayAdd()- using thestrdup()as we used till now causes memory leak.Reproducer is the same as #813 .