Use CFStringCreateWithCStringNoCopy when the CFString doesn't outlast the char * #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AZero13
force-pushed
the
cf
branch
2 times, most recently
from
7b9fc1c to
3db0ca6
Compare
… the char * The object is freed before anything happens to the pointers.
|
OK, as this code works as-is, I'm not inclined to make changes and none of this code gets any real testing thanks to sandboxing restrictions on macOS. |
michaelrsweet
added
wontfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The object is freed before anything happens to the pointers.