Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set authentication as required if the value is not "none" (fixes #1037) #1039

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

zdohnal
Copy link
Member

@zdohnal zdohnal commented Aug 29, 2024

No description provided.

Copy link
Member

@michaelrsweet michaelrsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just compare for inequality to “none”…

@zdohnal zdohnal force-pushed the air-dnssd-txt-fix branch from eaede95 to 319d630 Compare August 30, 2024 05:23
@zdohnal zdohnal force-pushed the air-dnssd-txt-fix branch from 319d630 to bec105f Compare August 30, 2024 05:25
@zdohnal zdohnal changed the title Support all standard-supported values (fixes #1037) Set authentication as required if the value is not "none" (fixes #1037) Aug 30, 2024
@zdohnal zdohnal requested a review from michaelrsweet August 30, 2024 05:27
Copy link
Member

@michaelrsweet michaelrsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zdohnal zdohnal merged commit 80f7ad1 into OpenPrinting:master Sep 2, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants