Merge fix for #829

OpenPrinting · Nov 24, 2023 · 0e3fe78 · 0e3fe78
1 parent 7d01ce5
commit 0e3fe78
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -6,6 +6,8 @@ Changes in CUPS v2.4.8 (TBA)
 
 - Added new value for 'lpstat' option '-W' - successfull - for getting
   successfully printed jobs (Issue #830)
+- Added warning if the device has to be asked for 'all,media-col-database' separately
+  (Issue #829)
 - Fixed memory leak when creating color profiles (Issue #815)
 - Fixed memory leak when unloading a job (Issue #813)
 - Raised `cups_enum_dests()` timeout for listing available IPP printers (Issue #751)

diff --git a/scheduler/ipp.c b/scheduler/ipp.c
@@ -5409,6 +5409,10 @@ create_local_bg_thread(
       if ((attr = ippFindAttribute(response2, "media-col-database",
 				   IPP_TAG_ZERO)) != NULL)
       {
+	cupsdLogMessage(CUPSD_LOG_WARN, "The printer %s does not support requests"
+			" with attribute set \"all,media-col-database\", which breaks IPP"
+			" conformance (RFC 8011, 4.2.5.1 \"requested-attributes\")"
+			" - report the issue to your printer manufacturer", printer->name);
        /*
 	* Copy "media-col-database" attribute into the original
 	* IPP response