Consider minimum area and length in combined symbols #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combined symbols may contain areas with a minimum size, either in area symbols or private sub-symbols. Closes OpenOrienteeringGH-2083.
Combined symbols may contain lines with a minimum size, either in line symbols or private sub-symbols.
|
IMO we want the MAXIMUM minimum value from all subsymbols. |
|
PR looks good to me. Thank you for the improvements Kai. |
dg0yt
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined symbols may contain areas with a minimum size, either in area symbols or private sub-symbols.
Combined symbols may contain lines with a minimum size, either in line symbols or private sub-symbols.
This is an alternative implementation of GH-2084.
Closes GH-2083.