Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore virtual gaps in line objects #2266

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dl3sdo
Copy link
Member

@dl3sdo dl3sdo commented Jul 29, 2024

Line objects in .ocd files can contain virtual gaps, i.e., gaps that interrupt the line but keep the object as a single object.
Mapper does not yet support virtual gaps and thus ignores them when importing .ocd files.
Issue a warning that virtual gaps in line objects are not supported.
The current PR is a WIP as it depends on merging #2224.
If there a multiple objects with virtual gaps, only one warning should be issued. This is being accomplished by the first commit (which is a modified version of the one in #2124).

@dl3sdo dl3sdo marked this pull request as draft July 29, 2024 15:52
@dl3sdo
Copy link
Member Author

dl3sdo commented Jul 29, 2024

VirtualGaps2

Note: the 2nd object (motorway) is different as only the border lines are interrupted. This is stored differently in the object compared to virtual gaps.

dl3sdo added 3 commits July 30, 2024 15:47
In addition to 'addWarning()' 'addWarningOnce()' only adds a warning to
the list of warnings if the warning is not yet in the list.
Line objects in .ocd files can contain virtual gaps, i.e., gaps that
interrupt the line but keep the object as a single object.
Mapper does not yet support virtual gaps and thus ignores them when
importing .ocd files.
Issue a warning that virtual gaps in line objects are not supported.
Double line objects use symbols with boundary lines (e.g., Wide road
symbol). In .ocd files these objects may have gaps in any of the
boundary lines.
Mapper does not support those kind of gaps and thus ignores them when
importing .ocd files.
Issue a warning that gaps in double line objects are not supported.
@dl3sdo dl3sdo force-pushed the ignore-virtual-gaps branch from 2d25290 to 8ce527f Compare July 30, 2024 13:52
@dl3sdo
Copy link
Member Author

dl3sdo commented Jul 30, 2024

Behaviour with current PR:
VirtualGaps2Imported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant