Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISOM 2017-2 #1363

Merged
merged 39 commits into from
Sep 28, 2019
Merged

ISOM 2017-2 #1363

merged 39 commits into from
Sep 28, 2019

Conversation

dg0yt
Copy link
Member

@dg0yt dg0yt commented Sep 19, 2019

Attempt to eventually merge the work of @Symbian9 and @yevhenmazur, but documenting major changes and decisions.

Task: GH-1184

@dg0yt dg0yt force-pushed the isom_2017-2 branch 2 times, most recently from 923cbf7 to bdbfcb3 Compare September 20, 2019 07:13
We need to retain the original version for now in order to retain the
translations which are bound to the 'ISOM2017' context.
"If yellow coloured areas become dominant, a screen (75% instead of
full yellow) may be used." (IOF: ISOM 2017-2).

For letting symbol set users easily switch between both options, it
is neccessary to create a single explicit map color for use with the
affected area features. Users now just need to adjust the percentage
of yellow in a single place: this map color. All affected symbols
will be updated immediately. The original full tone (spot color)
"Yellow" must remains unchanged, as base for derived map colors (such
as the background for "Narrow ride", or "Yellow 100%/Green 50%" for
"Area that shall not be entered").

This implemenation intentionally deviates from IOF Map Commission's
"Colours ISOM 2017-2.pdf" which lists separate map colors "Yellow
100% - Area Feature" and "Yellow 75% - Area Feature". That approach
would require touching each affected symbol individually.
This color is just above yellow, for implementing black dots for
"Cultivated Land" and "Sandy ground".

This implementation is based on, but intentionally deviates at
least from the naming of, "Black for Cultivated Land" in IOF Map
Commission's "Colours ISOM 2017-2.pdf". This implementation is chosen
to allow green patches and similar on top of the named symbols.
Increase 20% -> 30%, 50% -> 60%.
Do not append "- Area Feature": We will use "Green 60%" also for
"[Rough] Open land with scattered trees".
For "[Rough] Open land with scattered trees", now replaced with
regular "Green 60%".
Formerly known as "Green 50%/Yellow".
This includes two area symbols and the "Green, Black 50%" color.
The line symbol uses regular opaque green for the moment.
Increase Green 20% -> 30%, 50% -> 60%.
Change order to match "Colours ISOM 2017-2.pdf".
Create a lower "Brown 50% - Area Feature" in addition to what becomes
"Brown 50% - Street Infill" now.
Preliminary adjustment of road symbols.
Move existing colors down, and adjust name.
To be used for a dedicated symbol for dominant areas of "Uncrossable
body of water".
Intentionally not used for our "Building, minimum size" symbol.
Formerly known as "Opaque White below Black".
Current not used by a symbol.
Older version used to create and save empty start/middle/end/dash
point symbols for each line symbol. This is no longer the case.
But normally, they are dropped only when editing symbols.
Keep the two variants of Brown 50% close together, above the shades
of Blue for area features. Have a Black below each Brown 50%. Update
the symbols which need Brown 50% so that they play together well.
(Note that the explicit "Paved area, bounding line" symbol now uses
"Black below Purple for Track symbols".)

For consistent behaviour within our symbol set, and as already
implemented in our ISOM2017 symbol set, place the Browns and Blacks
above the shades of Blue for area symbols, but below the shades of
Black for buildings. This intentionally deviates from IOF Map
Commission's color level proposals which seem to be hard to use
in practice.
Place it under Blue for area features. This is roughly where it used
to be in our ISOM2017 symbol set, properly below Purple for Track
Symbols.
...to use "Purple for Track Symbols".
@dg0yt
Copy link
Member Author

dg0yt commented Sep 21, 2019

Color overview

  • Knockout/overprinting might need a second look, but is deprecated anyway.
  • Color naming might need a second look.

ISOM-2017-2 colors

Partly based on contributions by:
Eugeniy Fedirets
Yevhen Mazur
Different levels of pure cyan are hard to distinguish on screen.
The 22 px custom symbols were created with 5% magenta for Blue 100%,
and with halftones reduced (70% -> 50%, 50% -> 25%).
Intentionally using Green+Purple instead of the original Green+Black.
@dg0yt dg0yt changed the title WIP: ISOM 2017-2 ISOM 2017-2 Sep 22, 2019
@dg0yt
Copy link
Member Author

dg0yt commented Sep 22, 2019

@dg0yt dg0yt self-assigned this Sep 22, 2019
@dg0yt dg0yt added this to the v0.9.0 milestone Sep 22, 2019
@dg0yt
Copy link
Member Author

dg0yt commented Sep 22, 2019

Note: For simplicity, I ignored the traditional, now-deprecated order of spot colors. I assume it will no longer have any use.

@Zerbembasqwibo
Copy link
Contributor

Stairways white doesn't cut the blue colors. Intentionally? (Railway-whit cut them)

When cheating with too short impassable fence or linear, it might appear two dots/tags and a short line. Wouldnt it be better the other way: the symbols appear first when line is longer then the distance between the "double symbols"? (Same with those symmbols but no "doubes, ordinary fence for example, but the problem is less.

@dg0yt
Copy link
Member Author

dg0yt commented Sep 25, 2019

Stairways white doesn't cut the blue colors. Intentionally? (Railway-whit cut them)

I wonder if there should be white at all. The ISOM only mentions black.
Apart from that, I don't expect stairways (up/down) to cut water features (flat). However, we probably don't want the white to cover magnetic north lines, paved areas, contour lines, track symbols.

When cheating with too short impassable fence or linear, it might appear two dots/tags and a short line. Wouldnt it be better the other way: the symbols appear first when line is longer then the distance between the "double symbols"?

The question is if "cheating" should be impossible, hard, or convenient. Without the "decorations", the symbol is incomplete and can be misunderstood.
The same for a narrow ride which is too short. It doesn't become unambiguous by drawing a gap between tiny dashes.

Required for dashed variant of Distinct vegetation boundary (416),
cf. GH-1184.
Use combined symbol based on Open land (401) and the black pattern
variant of Cultivated land (412.1).
@dg0yt dg0yt merged commit ffd4a08 into master Sep 28, 2019
@dg0yt dg0yt deleted the isom_2017-2 branch September 28, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants