Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISOM 2017-2 #1184

Closed
Zerbembasqwibo opened this issue Nov 27, 2018 · 44 comments
Closed

ISOM 2017-2 #1184

Zerbembasqwibo opened this issue Nov 27, 2018 · 44 comments

Comments

@Zerbembasqwibo
Copy link
Contributor

IOF MC will update ISOM 2017. Find document on decided changes and status of discussion right now here.

https://orienteering.org/wp-content/uploads/2018/11/ISOM-2017-corrections-approved-2018-11.pdf

"These updates are approved and should be implemented for ongoing mapping projects using the ISOM 2017 standard."

@dg0yt dg0yt added this to the v0.8.4 milestone Nov 27, 2018
@ghost
Copy link

ghost commented Nov 29, 2018

Also here is original post by IOF:

The most significant updates to the ISOM 2017 standard are

  • The removal of symbol 411 Vegetation, Impassable
  • The inclusion of a new symbol for Stairway

These updates are approved and should be implemented for ongoing mapping projects using the ISOM 2017 standard.

And here is discussion in Orienteering Mappers Int. group on Facebook:

Additionally here are notes from Minutes – Foot Orienteering Commission – Meeting 4-2018 (Scandic Plaza Borås, Sweden)

Mapping issues

The IOF Map Commission proposed to publish a revision of ISOM 2017. According to AL, the biggest proposed change is to terminate using the impassable vegetation (100% green, 50% black) symbol.

FOC supports this change. PM noted that the new forbidden area symbol hides too many features on the map. This is in particular a problem when the border of the forbidden area is not marked in the terrain. No further action required from FOC.

@lpechacek
Copy link
Member

As to my understanding the changes to ISOM2017 affect primarily Mapper data sets. I.e. no programming skills are required to make the changes. Any volunteers to tackle the topic so that your friendly programmers have more time for hacking on the code?

@mlerjen
Copy link
Contributor

mlerjen commented Nov 29, 2018

I could (try to) do that, but would need more specific instructions.

@yevhenmazur
Copy link

I'll be ready to commit to this task in a few days.

@lpechacek
Copy link
Member

@mlerjen, @yevhenmazur I'm glad for your offer of help!

Symbian9 already started work on the symbol set adjustment. Please download and review changed files from his GitHub repository. The raw symbol set file is now at https://raw.githubusercontent.com/Symbian9/mapper/patch-2/symbol%20sets/src/ISOM2017_15000.xmap (click on the link and save the file into permanent storage). More detailed view of the changes can be seen in pull request #1187 - Commits tab and Files changed

IMHO review focus should be put on color table, dropped and changed symbols, changed symbol descriptions and their minimal sizes. However, I believe that this is your domain of expertise and you perhaps know better than me what to watch for.

Thanks!

@dg0yt dg0yt removed this from the v0.8.4 milestone Dec 23, 2018
@ghost
Copy link

ghost commented Jan 1, 2019

Should we rename this issue to «ISOM 2019» according @krticka's comment?

At least you have to wait with ISOM 2019 for official PDF where dimensions of new symbols will be defined.

@ghost
Copy link

ghost commented Jan 27, 2019

ISOM 2017-2

@krticka said that next ISOM spec would be named as «ISOM 2017-2»

Busy days for Map commission on IOF Joint Meeting in Warsaw, Poland. Just short information what we were working on:

  • We finalized update of ISOM 2017 (there were many discussions about the name in IOF and it will be ISOM 2017-2)
  • We discussed development of new ISMTBOM with MTBO Commission
  • We finalized update of ISSkiOM
  • We finalized most of the issues with ISSprOM
  • We updated some information in new WRE manual regarding maps
  • Long discussion about map quality for major IOF events and role of SEA in assessment of map quality
  • Map quality and technical desk-review process for IOF major events - tasks for next 2 years were distributed within commission members
  • Symbol set for school orienteering maps is ready and will be published on IOF webpage
  • New PrintTech Sheet was discussed and some issues must be fixed

IOF MC, 2019/01/19

P.S.: IOF MC resources

@dg0yt
Copy link
Member

dg0yt commented Jan 28, 2019

Please stop the noise. No need to copy FB or link the IOF page.

@mlerjen
Copy link
Contributor

mlerjen commented Aug 25, 2019

@yevhenmazur: Note, that this issue is still open. I am off for two weeks now. If you did not fix it until then, I'll try to. https://orienteering.sport/iof/resources/mapping/

@ghost
Copy link

ghost commented Aug 26, 2019

If you did not fix it until then, I'll try to.

IOF Map Commission meeting minutes 2019-2 has just been published with new addition and changes, and I don't know when finally final versions of specification would be released.

That is one of reasons why I paused updating symbol sets. Still waiting for freezing IOFs' specification development until MC will release final version of ISOM and ISSprOM specifications. There are many issues with adaptation of specifications that are in "rolling release" stage.

@krticka
Copy link
Contributor

krticka commented Aug 26, 2019 via email

@ghost
Copy link

ghost commented Aug 26, 2019

There were not any changes since the publication of ISOM 2017-2 and ISSprOM 2019.

If so, it is so much the worse, as there are many issues with colors and symbol numbering already reported by many mappers since ISOM 2017-2 and ISSprOM 2019 specifications released.

@krticka
Copy link
Contributor

krticka commented Aug 26, 2019

  1. Not sure what you mean by the "issues". If there are any inconsistencies you don't understand or you think they are not correct please contact MC officially via email and explanation will be given.
  2. Once again, there were no new changes to the specifications (last change was publication of ISSprOM and small corrections of few unimportant details in ISOM2017-2 in April)
  3. Since the middle of June colour order (and colour shades for offset) are published on MC pages for both specifications, see "Other mapping related documents" section

@ghost
Copy link

ghost commented Aug 26, 2019

If there are any inconsistencies you don't understand or you think they are not correct please contact MC officially via email and explanation will be given.

OK. Please, @krticka, provide email for contact with MC.

@krticka
Copy link
Contributor

krticka commented Aug 26, 2019 via email

@yevhenmazur
Copy link

I'm ready with ISOM 2017-2. You can get current version from this page. There were much more changes than I expected...

@krticka
Copy link
Contributor

krticka commented Aug 31, 2019

For ISOM 2017-2 I was not checking all dimensions and colours but it looks very good. For 532 Stairway I would recommend also to add variant without borderlines (just steps) as specification says:
"A stairway going through rock passages or between impassable objects may be drawn without border lines."

@yevhenmazur
Copy link

Add Stairway without border lines - done.

@krticka
Copy link
Contributor

krticka commented Sep 1, 2019

Good. Just it is needed to adjust the width for both stairway symbols and make them slightly wider as minimum width is 0.4 mm (inside measure).

@yevhenmazur
Copy link

Adjust the width for stairway symbols - done.

I think you should add (IM) on the illustration as it is done for other symbols. I'll add this point to feedback from our federation.

@dg0yt dg0yt pinned this issue Sep 16, 2019
@dg0yt dg0yt changed the title ISOM 2017 rev. 2018-11 ISOM 2017-2 Sep 16, 2019
@mlerjen
Copy link
Contributor

mlerjen commented Sep 16, 2019

Thanks Yevhen. Still I think, we should try to get further to regive ISOM in its entirety. Not just symbol and colors but also section 2.11. The Symbols of our Standard Symbol Set should contain buffers to represent minimum gaps, lengths and widths.

image
fig.1 Minmum gaps and -length for 203 cliff and minimum width for 403 rough open land.

Part we could solve with buffers as shown in fig.1. Here the introduction of helper colors (not on the final map, easily to be switched on and off) would be helpful. (Now they are just white and at the bottom of the color table). Other parts (minimal size) would be more complex to achieve as discussed earlier #1021 #610

@lpechacek
Copy link
Member

I concur. I don't see a minimum gap checker coming into Mapper anytime soon therefore I'd love to see the symbol set support visual checks. Not only as a "good idea" but also for my work.

@valdisj
Copy link

valdisj commented Sep 18, 2019

The symbol setts in here only do work with MAPPER 0.9 or also 0.8.4? https://github.com/yevhenmazur/mapper/tree/issprom2019/symbol%20sets/src

@ghost
Copy link

ghost commented Sep 18, 2019

I don't see a minimum gap checker coming into Mapper anytime soon

We has separate issue for legibility checker:

@ghost
Copy link

ghost commented Sep 18, 2019

The symbol setts in here only do work with Mapper 0.9.x or also 0.8.4?

@valdisj, You could just try open it in 0.8.4 — if there are some problems Mapper will show you warning message with details.

FTR, You should download and open described symbols manually, because it not distributed with Mapper 0.8.4 and 0.9.xyet!

@yevhenmazur
Copy link

The symbol sets designed for Mapper 0.9, however, no 0.9-specific features are used here. So you may ignore the warning and test symbol sets with Mapper 0.8 safely. If you face a problem please report - it is always welcome.

@dg0yt dg0yt mentioned this issue Sep 19, 2019
@dg0yt
Copy link
Member

dg0yt commented Sep 20, 2019

@krticka Symbol 408 "Vegetation: Walk" mentions "white / green 20% stripes". Is this level of green intentional, or the last remainder of what is now "green 30%"?

@dg0yt
Copy link
Member

dg0yt commented Sep 20, 2019

@krticka Symbol 404 "Rough open land with scattered trees" mentions "yellow 35%". Is this level of yellow intentional? It is not referenced anywhere else.

@dg0yt
Copy link
Member

dg0yt commented Sep 21, 2019

@krticka Cultivated Land (412): "For agroforestry, symbol Forest (405) or Open land with scattered trees (402) may be used instead of yellow."

This specification is inconsistent: it mixes color and symbols. Either

  • Yellow is to be replaced with another color, or
  • Cultivated land (412) is to be replaced with the named symbols, or
  • Cultivated land (412) is just the black dots pattern, and it must to be combined with either Open land (401), Forest (405), Open land with scattered trees (402).

I always tended to assume the latter, which would let me adjust the black dots pattern independently from the yellow background, esp. close to roads, or to match seasonal changes. However, this POV seems to have no tradition, and if implemented, this approach would need to be extended to the other symbols which build on yellow background (Open land with scattered trees (402), Orchard (413), Vineyard or similar (414)).
And this would offer a different route to changing dominant Yellow 100% to Yellow 70%: Just choose a different yellow in Open land (401), the only remaining use.

@dg0yt
Copy link
Member

dg0yt commented Sep 21, 2019

@krticka Symbol 407 is listed as "Vegetation, slow running, good visibility" but referenced as "Vegetation: slow running, good visibility" in Orchard (413).
The other variants all use "Vegetation: ...".

@dg0yt
Copy link
Member

dg0yt commented Sep 21, 2019

@krticka Distinct vegetation boundary (416): The dashed variant is to use "Colour: green and black 50%". Is this meant to be Green 100% now? AFAIU this mixed color is no longer used, at least after removing the ISSOM-style impassable vegetation.

@dg0yt
Copy link
Member

dg0yt commented Sep 22, 2019

@krticka Prominent vegetation feature (419): "White mask is used under the green cross, to improve readability in yellow and green (line width of white mask 0.36 mm, and it shall be 0.18 mm longer in the ends of the symbol)."
I think the last part is misleading: For a constant width white frame, the total length of a mask line is to be 0.18 mm longer. This is only 0.09 mm in each "end".

@dg0yt
Copy link
Member

dg0yt commented Sep 22, 2019

@krticka Major power line (511): The specification for the large carrying mast says 0.8 mm outer measure, 0.2 mm line width. However, the picture looks like the outer measure is 5x the line width, with the gap width being equal to the line width. When implementing the explicitly given values, the gap is just 0.1 mm, i.e. 0.5x the line width. This looks quite different.

@krticka
Copy link
Contributor

krticka commented Sep 25, 2019 via email

@dg0yt
Copy link
Member

dg0yt commented Sep 25, 2019

Inconsistency is sometimes needed, as there are different
legal issues in every country for entering such areas or they can vary
during the season because of mixed use.

Hm. I though I learned that the legal aspect of "entering such areas" is no longer relevant for "Cultivated land" as such, or for the map standards . It needs to be given separately, by Out-of-bounds area (709). And 709 doesn't care at all what other symbols it is covering.

Cultivated land (412) is just the black dots pattern,

So we are to remove the yellow background from Cultivated land, from Orchard, and from Vineyard, for consistency.

@krticka
Copy link
Contributor

krticka commented Sep 25, 2019 via email

@krticka
Copy link
Contributor

krticka commented Sep 25, 2019 via email

@krticka
Copy link
Contributor

krticka commented Sep 25, 2019 via email

@krticka
Copy link
Contributor

krticka commented Sep 25, 2019 via email

@krticka
Copy link
Contributor

krticka commented Sep 25, 2019 via email

@dg0yt
Copy link
Member

dg0yt commented Sep 26, 2019

Green and black 50% for 416 is correct because of readability reasons of boundaries used with 100 % green. It is the only symbol where such colour is used.

Another issue with the color documents...

dg0yt added a commit that referenced this issue Sep 26, 2019
Required for dashed variant of Distinct vegetation boundary (416),
cf. GH-1184.
@krticka
Copy link
Contributor

krticka commented Sep 26, 2019

I see. MC will do an update of colours document quite soon as ISSkiOM is finished and ISMTBOM is in the final stage.

@dg0yt
Copy link
Member

dg0yt commented Sep 26, 2019

I see. MC will do an update of colours document quite soon as ISSkiOM is finished and ISMTBOM is in the final stage.

If the MC defines the "order of main colour shades", it must be complete and consistent because then we must implement it in this way. The colour documents are of limited value unless there is no doubt which particular colour a symbol refers to. There is no room for "(will evt. be changed)".

@ghost
Copy link

ghost commented Sep 26, 2019

MC will do an update of colours document quite soon as ISSkiOM is finished and ISMTBOM is in the final stage.

I just curious, how many issues still not fixed in official IOF specifications? (that now used for real orienteering competitions)

@dg0yt dg0yt added this to the v0.9.0 milestone Oct 20, 2019
@dg0yt dg0yt closed this as completed Oct 20, 2019
@dg0yt dg0yt unpinned this issue Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants