Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix liblo 0.32 header compatibility #1954

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Fix liblo 0.32 header compatibility #1954

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/osc/OSCNode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ bool ExtractSlotValueFromPair(const string &type, lo_arg **argv,
* @param user_data a pointer to the OSCNode object.
*/
int OSCDataHandler(const char *osc_address, const char *types, lo_arg **argv,
int argc, void *, void *user_data) {
int argc, lo_message, void *user_data) {
OLA_DEBUG << "Got OSC message for " << osc_address << ", types are " << types;

OSCNode *node = reinterpret_cast<OSCNode*>(user_data);
Expand All @@ -150,7 +150,7 @@ int OSCDataHandler(const char *osc_address, const char *types, lo_arg **argv,

if (argc == 1) {
if (type == "b") {
lo_blob blob = argv[0];
lo_blob blob = (lo_blob)argv[0];
Copy link
Contributor Author

@cbix cbix Mar 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example code in liblo also uses a regular typecast:

https://github.com/radarsat1/liblo/blob/c1a51bca21e8535ce77a9daf256f2e74c1a7e80f/examples/example_server.c#L118:L131

unsigned int size = min(static_cast<uint32_t>(DMX_UNIVERSE_SIZE),
lo_blob_datasize(blob));
node->SetUniverse(
Expand Down
Loading