-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workarounds for selecting ElementCollection attributes #30581
workarounds for selecting ElementCollection attributes #30581
Conversation
…entCollection attribute, and otherwise improve conversions
#build (view Open Liberty Personal Build - ❌ completed with errors/failures.) Note: Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
...iberty.data.internal.persistence/src/io/openliberty/data/internal/persistence/QueryInfo.java
Show resolved
Hide resolved
Database Rotation SOE for this PR: https://libh-proxy1.fyre.ibm.com/cognitive-dev/pipelineAnalysis.html?pipelineId=24ac3a31-414e-4ba4-825c-bcf390c9866e Note: Target locations of links might be accessible only to IBM employees. |
...sistence/resources/io/openliberty/data/internal/persistence/resources/CWWKDMessages.nlsprops
Show resolved
Hide resolved
...sistence/resources/io/openliberty/data/internal/persistence/resources/CWWKDMessages.nlsprops
Outdated
Show resolved
Hide resolved
...sistence/resources/io/openliberty/data/internal/persistence/resources/CWWKDMessages.nlsprops
Outdated
Show resolved
Hide resolved
...sistence/resources/io/openliberty/data/internal/persistence/resources/CWWKDMessages.nlsprops
Show resolved
Hide resolved
...sistence/resources/io/openliberty/data/internal/persistence/resources/CWWKDMessages.nlsprops
Outdated
Show resolved
Hide resolved
...sistence/resources/io/openliberty/data/internal/persistence/resources/CWWKDMessages.nlsprops
Outdated
Show resolved
Hide resolved
New build needed due to additional commit with NLS message updates: Note: Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
The build has 1 failure, which is a preexisting intermittent issue in unrelated test bucket com.ibm.ws.jbatch.rest.api_fat Note: Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
EclipseLink has wrong behavior when ElementCollection attributes are selected, as shown by #30575
This PR puts in place the following workarounds, to the degree that we are able,
When a single result of a selected ElementCollection is returned, we can sometimes implement a workaround to identify the mismatch and generate the correct type of collection, populated with the results.
When multiple results of a selected ElementCollection are returned, EclipseLink combines the values into a single vector where it is impossible to split them back out into the separate results that they are. We attempt to detect this scenario and raise our own UnsupportedOperationException in order to spare the user from unexpected wrong behavior.
There are also some improvements in this area to type conversions.
release bug
label if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).