Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIPS work Integration #30557

Open
wants to merge 138 commits into
base: integration
Choose a base branch
from
Open

FIPS work Integration #30557

wants to merge 138 commits into from
+4,117 −2,571

Conversation

mshah0722
Copy link
Contributor

No description provided.

mshah0722 and others added 30 commits September 13, 2024 17:38
@mshah0722
Supporting FIPS work
6f1eb56
@mshah0722
Minor bug fixes
7efb1ad
@mshah0722
Minor changes
5f4264e
@utle
Use the common crypto bundle
9530112
@utle
Create the Provider class
67ca4cb
@utle
clean up
3b6d858
@mshah0722
Adding support to client and server for java 17
a671f21
@utle
Rename generate3DESKey method to generateSharedKey
a90e9bf
@mshah0722
Merge branch 'OpenLiberty:integration' into FIPSwork
85c2c57
@mshah0722
Fixing some test bugs
a4fa8ba
@mshah0722
Merge branch 'FIPSwork' of github.com:mshah0722/open-liberty into HEAD
e1cbd56
@mshah0722
Merge pull request #1 from utle/FIPSwork
cf9acf4 
Rename generate3DESKey method to generateSharedKey
@mshah0722
Minor bugs
d65866e
@utle
Added debug msgs
c04b999
@utle
SSL to use crypto common code
2123cf5
@mshah0722
Merge pull request #2 from utle/FIPSwork
af2fe51 
Fips work
@mshah0722
Merge branch 'OpenLiberty:integration' into FIPSwork
7df6665
@mshah0722
Restrict TLS versions for FIPS
cde667d
@mshah0722
Merge branch 'FIPSwork' of github.com:mshah0722/open-liberty into FIP…
2f16885 
…Swork
@mshah0722
Restrict TLS versions for FIPS
dea7785
@utle
Handle Semeru
ebaadc1
@mshah0722
Merging Ut's code
0d67b38
@utle
add common crypto to ssl feature
1692ecf
@mshah0722
Merge pull request #4 from utle/FIPSwork
d15c6d4 
add common crypto to ssl feature
@utle
enable openJCEPlusFips
ed707fa
@utle
clean up
6186795
@mshah0722
Merge pull request #5 from utle/FIPSwork
11f08a2 
Fip swork
@utle
enable openJCEPlusFips
3bc4615
@mshah0722
Merge remote-tracking branch 'ut_branch/FIPSwork' into FIPSwork
3bcc438
@mshah0722
Merge branch 'OpenLiberty:integration' into FIPSwork
a1994c1
jacobwdv and others added 24 commits December 7, 2024 14:05
@jacobwdv
Updating LibertyServer class so that other tests can configure LTPA k…
ce47641 
…eys and JVM options for FIPS (#16)

* updating LibertyServer
@mshah0722
Merge branch 'release' of github.com:OpenLiberty/open-liberty into FI…
13ef519 
…PSwork
@mshah0722
Fixing SSL and beta mode issue for Java 8
2cc2473
@mshah0722
Fixed the issue with IBMJCEPlusFIPSprovider not loading properly
b94e4cf
@mshah0722
Merge branch 'release' of github.com:OpenLiberty/open-liberty into FI…
cfa215e 
…PSwork
@utle
Merge branch 'FIPSwork' of github.com:mshah0722/open-liberty into FIP…
29dbbba 
…Swork
@utle
Fixed 140-2 check and adding more debug
914ebe7
@utle
adding more check
dd20353
@mshah0722
Merge branch 'release' of github.com:OpenLiberty/open-liberty into FI…
48badd8 
…PSwork
@utle
adding more check
73c9080
@mshah0722
Merge branch 'FIPSwork' of github.com:utle/open-liberty into FIPSwork
4569d99
@mshah0722
Merge branch 'release' of github.com:OpenLiberty/open-liberty into FI…
b66c91c 
…PSwork
@jacobwdv
updating server xml's with appropriate passwords, renaming serverFIPS…
adda4f7 
….xml before server start

adding AEADBadTagException to AllowedFFDC list for tests which expect BadPaddingException

using jvm.options so that mbean invocations will use proper jvm parameters
@jacobwdv
wip
15c328a
@mshah0722
Merge branch 'release' of github.com:OpenLiberty/open-liberty into FI…
c3d2bc5 
…PSwork
@mshah0722
Merge pull request #18 from jacobwdv/JD_LTPAKeyTest
f9d5812 
updating server xml's with appropriate passwords, renaming serverFIPS…
@mshah0722
Merge branch 'FIPSwork' of github.com:mshah0722/open-liberty into FIP…
3253d05 
…Swork
@jimmy1wu
Merge remote-tracking branch 'origin/release' into FIPSwork_01072025
3221f8e
@utle
Handle FIPS 140-2 and 140-3 separated to keep the current behavior
4689e3d
@jimmy1wu
Merge remote-tracking branch 'ut_fork/FIPSwork' into FIPSwork_01072025
58df82d
@utle
Fixed FIPS140-2 enabled
d39aee3
@jimmy1wu @utle
remove duplicate ltpa config in nonFIPS case
9fa333d
@jimmy1wu
comment out common.crypto trace
e3eb7a1
@mshah0722
Merge branch 'FIPSwork_01072025' of github.com:jimmy1wu/open-liberty …
80990c0 
…into FIPSworkIntegration
@mshah0722
Copy link
Contributor Author

mshah0722 commented Jan 14, 2025 •
edited by LibbyBot
Loading

#libby
(view Open Liberty Delivery Requirements Verification - ✅ completed successfully!) (view Open Liberty Personal Build - ❌ completed with errors/failures.)
!build

git.clone.checkout.branch=FIPSworkIntegration
git.clone.repository.username=Malhar-Shah

#spawn.fullfat.buckets=com.ibm.ws.security.token.ltpa_fat

Note: Target locations of links might be accessible only to IBM employees.

Note: Target locations of links might be accessible only to IBM employees.

@mshah0722
Copy link
Contributor Author

Manual PB for both OL and CL PRs
https://wasrtc.hursley.ibm.com:9443/jazz/web/projects/WS-CD#action=com.ibm.team.build.viewResult&id=_9OHw4NK7Ee-oy5en10XsVA

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 455 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 2 unit test files were changed.

  • Check that the build did not break the affected unit test suite(s).

  • 8 infrastructure code files were changed.

  • 9 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • 70 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 16 messages files were changed and need an L2 review.

  • @OpenLiberty/message-reviewer Please review.

    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh_TW.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_it.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_cs.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ja.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_fr.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages.nlsprops
    • dev/com.ibm.ws.kernel.service/resources/com/ibm/ws/kernel/pseudo/internal/resources/Messages.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_de.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pt_BR.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ro.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ru.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pl.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_hu.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ko.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_es.nlsprops

  • 16 NLS files were changed and need an ID review.

  • @OpenLiberty/message-reviewer Please review.

    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh_TW.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_it.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_cs.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ja.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_fr.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages.nlsprops
    • dev/com.ibm.ws.kernel.service/resources/com/ibm/ws/kernel/pseudo/internal/resources/Messages.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_de.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pt_BR.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ro.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ru.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pl.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_hu.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ko.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_es.nlsprops

@LibbyBot
Copy link

Please code review feature-related files, @OpenLiberty/delivery-approvers

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 455 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 2 unit test files were changed.

  • Check that the build did not break the affected unit test suite(s).

  • 8 infrastructure code files were changed.

  • 9 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • 70 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 16 messages files were changed and need an L2 review.

  • @OpenLiberty/message-reviewer Please review.

    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh_TW.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_it.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_cs.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ja.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_fr.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages.nlsprops
    • dev/com.ibm.ws.kernel.service/resources/com/ibm/ws/kernel/pseudo/internal/resources/Messages.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_de.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pt_BR.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ro.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ru.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pl.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_hu.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ko.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_es.nlsprops

  • 16 NLS files were changed and need an ID review.

  • @OpenLiberty/message-reviewer Please review.

    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh_TW.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_it.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_cs.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ja.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_fr.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages.nlsprops
    • dev/com.ibm.ws.kernel.service/resources/com/ibm/ws/kernel/pseudo/internal/resources/Messages.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_de.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pt_BR.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ro.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ru.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pl.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_hu.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ko.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_es.nlsprops

@LibbyBot
Copy link

Please code review feature-related files, @OpenLiberty/delivery-approvers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mshah0722 @LibbyBot @utle @jimmy1wu @jacobwdv