Fixes #337 - Command fix for project path with spaces #355
Conversation
Fix added for the command with space in dir.
There was a problem hiding this comment.
Please also update the copyright date for libertyProject.ts.
This is not a requirement for this issue, but as a general note, if you notice you are writing the same lines of code in multiple places and the pattern looks similar in those areas, it is good to consider if there is a chance to reuse common code from those areas. For instance, the startDevMode, startContainerDevMode and customDevMode functions.
There was a problem hiding this comment.
Looks good! There are some new comments to address, though.
I particularly like the new way that you structured the code for building the various commands and the fact that you reused the "command building" code for common shell types and across both Maven and Gradle. It really cuts down on code duplication. Moving the common code for creating a new terminal to its own method was also a nice touch. Nice job!
Did you re-test with the newly structured code to confirm it behaves the same?
Co-authored-by: Trevor Crawford <[email protected]>
|
Thanks for the review. I have tested all the scenarios with updated code. It is working as expected. |
Fixes #337
Fix for the issue - 'No such file or directory' raised for the start, start in container and start .. action of LTV dashboard for a project opened from the directory with space and project name with space.