Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check test reports when Maven report generator 3.4 and 3.5 is used #980

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

turkeylurkey
Copy link
Member

Updated two test cases to focus on the report generator.

Existing test case MavenSingleModMPProjectTest already tests the integration and unit test reports. We delete the Maven cache of the Maven plugins so that they must be downloaded when used. The report generator plugin is not called out in the pom so when we run the tests dev mode downloads the latest report generator, 3.5.0. The test also deletes existing reports before it begins so we validate that the 3.5 test report is generated and the 3.4 is not.

Existing test case MavenSingleModMPSIDProjectTest also tests the reports. Again we delete the Maven cache and the existing test reports. This test case copies all the files into a new directory so we can safely modify pom.xml to specify Maven report generator 3.4.0 (this will all be deleted afterwards). When tests are run we validate that the 3.4 location was used and the 3.5 location is not.

Fixes #940

@turkeylurkey
Copy link
Member Author

turkeylurkey commented Sep 17, 2024

From the build on my fork:
Windows: 148 tests completed, 1 failed, 16 skipped The one failure is Hover on text: NONE did not trigger a pop-up window, a known failure #945
Build on main still running.

@turkeylurkey
Copy link
Member Author

turkeylurkey commented Sep 17, 2024

From the build on my fork:
Mac: 123 tests completed, 3 failed, 12 skipped All three are initialization errors so no videos available. Similar to #971
Build on main still running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Add new tests to cover the two locations for test reports
1 participant