Fix valueNoSend: Do NOT End KO Uninitialized when Value Conversion …

…Failed
OpenKNX · Nov 1, 2024 · 483d868 · 483d868
1 parent 3de8903
commit 483d868
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/knx/group_object.cpp b/src/knx/group_object.cpp
@@ -282,10 +282,11 @@ void GroupObject::valueNoSend(const KNXValue& value)
 
 void GroupObject::valueNoSend(const KNXValue& value, const Dpt& type)
 {
-    if (_commFlagEx.uninitialized)
-        commFlag(Ok);
+    const bool encodingDone = KNX_Encode_Value(value, _data, _dataLength, type);
 
-    KNX_Encode_Value(value, _data, _dataLength, type);
+    // initialize on succesful conversion only
+    if (encodingDone && _commFlagEx.uninitialized)
+        commFlag(Ok);
 }
 
 bool GroupObject::valueNoSendCompare(const KNXValue& value, const Dpt& type)