Improve Testing Infrastructure #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnesbitt
force-pushed
the
testing-infrastructure
branch
3 times, most recently
from
19a8959 to
e9986a4
Compare
jjnesbitt
force-pushed
the
testing-infrastructure
branch
from
f040029 to
d7a31ae
Compare
jjnesbitt
force-pushed
the
testing-infrastructure
branch
from
d7a31ae to
a22252a
Compare
annehaley
reviewed
Nov 8, 2024
There was a problem hiding this comment.
I was originally hesitant about removing so much API code, but after some thought I agree that shrinking our API surface to only what we actively use is a good approach for now, especially in the context of fully testing the API. We only need to worrry about a robust API when we get users that would leverage it.
I'm excited about this new test suite, especially since it helped reveal some bugs that you fixed. The permissions testing is much stronger now, and I'm glad for the time we'll get back by scheduling the slow tests.
Just a few questions on minor things, but overall this looks good.
This was
linked to
issues
Nov 12, 2024
Closed
Closed
annehaley
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the testing infrastructure of the UVDAT API, through the addition of pytest fixtures, factory-boy factories, and some core tests. These tests aren't fully expansive, and don't cover every possible scenario, but instead attempt to test the core business logic that is already implemented. Many of the default views that we leverage from DRF are not explicitly tested, as we do very little (if any) modification of those viewset behaviors, and as such we would simply be testing DRF itself.
Some side effects of this PR: