Flood Timeseries Dataset #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnesbitt
requested changes
Nov 6, 2024
| # this was built for the Boston Flood Timeseries dataset. | ||
| import large_image_converter | ||
|
|
||
| if file_item.file_type == 'zip': |
There was a problem hiding this comment.
Suggested change
| if file_item.file_type == 'zip': | |
| if file_item.file_type != 'zip': | |
| return |
Comment on lines
+50
to
+53
| def split_raster_zip(file_item, style_options): | ||
| """For each raster image in a zip file, create a new FileItem.""" | ||
| # NOTE: This implementation is not abstract; | ||
| # this was built for the Boston Flood Timeseries dataset. |
There was a problem hiding this comment.
If this is the case, I think the function should be labeled as such.
| def create_raster_map_layer(file_item, style_options): | ||
| """Save a RasterMapLayer from a FileItem's contents.""" | ||
| if style_options is None: | ||
| style_options = {} | ||
| if file_item.file_type == 'zip': |
There was a problem hiding this comment.
Similar to my other comment, if the logic for extracting this data is specific to the boston flood timeseries dataset, a comment here explaining that would be good. That way, in the future, we know this is not general behavior.
|
After a team discussion about changing the relationships between Projects, Datasets, and Layers, we decided that this implementation will soon be non-applicable. This PR will be closed and revisited after the design change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #75.
This PR adds the simulated flood timeseries dataset created by Jack Watson. This involves the addition of a custom ingest function to split a single zip file item into many tiff file items. The current implementation is not abstracted; it relies on the presence of
vrtfiles in the zip and relies on the file names to assert ordering.Additionally, this PR adds animation controls to the current layer slider so that the user can automatically step through the layers on a dataset. The video (2x speed) below demonstrates this behavior on the flood timeseries dataset.
uvdat_flood_timeseries.mp4