-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
383 get connected subgraphs in an alchemicalnetwork #409
383 get connected subgraphs in an alchemicalnetwork #409
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #409 +/- ##
=======================================
Coverage 98.65% 98.65%
=======================================
Files 36 36
Lines 2075 2087 +12
=======================================
+ Hits 2047 2059 +12
Misses 28 28 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
I'm not convinced that Maybe |
e773c1a
to
aff2dfb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small things, otherwise lgtm.
gufe/tests/test_alchemicalnetwork.py
Outdated
@@ -47,3 +47,22 @@ def test_connectivity(self, benzene_variants_star_map): | |||
else: | |||
edges = alnet.graph.edges(node) | |||
assert len(edges) == 0 | |||
|
|||
def test_connected_subgraphs(self, benzene_variants_star_map): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add a brief test that checks that this works for fully connected graph? i.e. it just returns itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes good idea. I rearranged the fixtures a bit so we can access either one or both of the ligand and complex star networks for the benzene test case. I think this is the clearest way to do this without duplicating too much code.
5dda4c0
to
0c982ee
Compare
Co-authored-by: Irfan Alibay <[email protected]>
addresses #383