-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a generic atom mapping scorer #306
Conversation
Hello @RiesBen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-08-27 15:32:59 UTC |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
==========================================
- Coverage 98.94% 98.84% -0.10%
==========================================
Files 36 37 +1
Lines 1988 1998 +10
==========================================
+ Hits 1967 1975 +8
- Misses 21 23 +2 ☔ View full report in Codecov by Sentry. |
Absolutley agree with @richardjgowers
adjusting to comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
block pending discussion
moved to Fe setup structure #346 |
this is a generic interface for all openFE scorers.
Todo: