Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure cost and its subclasses #1999

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

LillyG901
Copy link
Contributor

@LillyG901 LillyG901 commented Dec 14, 2024

Summary of the discussion

See #1914

Type of change (CHANGELOG.md)

Update

  • make cost (and all its subclasses) subclass of process attribute

Workflow checklist

Automation

Closes #1914

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@github-actions github-actions bot added the oeo-social changes the oeo-social module label Dec 14, 2024
@LillyG901 LillyG901 marked this pull request as ready for review January 13, 2025 10:52
@stap-m stap-m requested review from stap-m and madbkr January 14, 2025 12:38

make subclass of process attribute
issue: https://github.com/OpenEnergyPlatform/ontology/issues/1914
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1999",
<http://purl.obolibrary.org/obo/IAO_0000112> "An example for variable cost are costs incurred for raw materials (of which more are needed if production is increased).",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<http://purl.obolibrary.org/obo/IAO_0000112> "An example for variable cost are costs incurred for raw materials (of which more are needed if production is increased).",
<http://purl.obolibrary.org/obo/IAO_0000112> "An example for variable production cost are costs incurred for raw materials (of which more are needed if production is increased).",

Just spotted, that the label in the definition and comment are misleading.


make subclass of process attribute
issue: https://github.com/OpenEnergyPlatform/ontology/issues/1914
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1999",
<http://purl.obolibrary.org/obo/IAO_0000112> "An example for variable cost are costs incurred for raw materials (of which more are needed if production is increased).",
<http://purl.obolibrary.org/obo/IAO_0000115> "Variable costs are costs that depend on the amount of goods or services produced and which are paid by the producer.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<http://purl.obolibrary.org/obo/IAO_0000115> "Variable costs are costs that depend on the amount of goods or services produced and which are paid by the producer.",
<http://purl.obolibrary.org/obo/IAO_0000115> "Variable production costs are costs that depend on the amount of goods or services produced and which are paid by the producer.",

@@ -8,6 +8,9 @@ and the versioning aims to respect [Semantic Versioning](http://semver.org/spec/
### Added
- conceptual model (#1976)

### Changed
- restructure cost and its subclasses (#1999)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend to just mention the classnames that were changed, in this case maybe cost and the first level of children. The classes were not actually restructured but just moved. However, we usually don't mention, what we did (which can be found in the term trackers).

@stap-m
Copy link
Contributor

stap-m commented Jan 14, 2025

There is one axiom of social cost which can be deleted without discussion, which is the one to the obsolete class 'economic value'. Seems like we missed to remove it once we made the relation obsolete...

@madbkr
Copy link
Contributor

madbkr commented Jan 15, 2025

I started the reasoner (used HermiT) and for me cost and all its subclasses are equivalent to owl:Nothing. Here is the explaination that Protegé offered:

Bildschirmfoto vom 2025-01-15 13-38-08

So we have to make more changes if we want to move cost like this.

@stap-m
Copy link
Contributor

stap-m commented Jan 15, 2025

Good catch @madbkr

@areleu
Copy link
Contributor

areleu commented Jan 15, 2025

I started the reasoner (used HermiT) and for me cost and all its subclasses are equivalent to owl:Nothing. Here is the explaination that Protegé offered:

Bildschirmfoto vom 2025-01-15 13-38-08

So we have to make more changes if we want to move cost like this.

That is a tricky one, but I can imagine this will happen to any other quantity values that are directly converted to process attributes, at least those with the has unit axiom.

@stap-m
Copy link
Contributor

stap-m commented Jan 15, 2025

We discussed in #1875 which former quantity values are actually quantities or process attributes. This PR is part of the restructuring. Both quantities and process attributes can be "measured" by quantity values, which are allowed for units. Therefore, I guess the solution is to change the axiomatisation: remove the "has unit" axioms for all process attributes and replace them with has quantity value linking to a corresponding quanity value.

@stap-m
Copy link
Contributor

stap-m commented Jan 16, 2025

And the corresponding quantity value would be monetary value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-social changes the oeo-social module
Projects
Status: Review in progress
Development

Successfully merging this pull request may close these issues.

cost subclasses have to be rescructured according to #1875
4 participants