-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure cost and its subclasses #1999
base: dev
Are you sure you want to change the base?
Restructure cost and its subclasses #1999
Conversation
|
||
make subclass of process attribute | ||
issue: https://github.com/OpenEnergyPlatform/ontology/issues/1914 | ||
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1999", | ||
<http://purl.obolibrary.org/obo/IAO_0000112> "An example for variable cost are costs incurred for raw materials (of which more are needed if production is increased).", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<http://purl.obolibrary.org/obo/IAO_0000112> "An example for variable cost are costs incurred for raw materials (of which more are needed if production is increased).", | |
<http://purl.obolibrary.org/obo/IAO_0000112> "An example for variable production cost are costs incurred for raw materials (of which more are needed if production is increased).", |
Just spotted, that the label in the definition and comment are misleading.
|
||
make subclass of process attribute | ||
issue: https://github.com/OpenEnergyPlatform/ontology/issues/1914 | ||
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1999", | ||
<http://purl.obolibrary.org/obo/IAO_0000112> "An example for variable cost are costs incurred for raw materials (of which more are needed if production is increased).", | ||
<http://purl.obolibrary.org/obo/IAO_0000115> "Variable costs are costs that depend on the amount of goods or services produced and which are paid by the producer.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<http://purl.obolibrary.org/obo/IAO_0000115> "Variable costs are costs that depend on the amount of goods or services produced and which are paid by the producer.", | |
<http://purl.obolibrary.org/obo/IAO_0000115> "Variable production costs are costs that depend on the amount of goods or services produced and which are paid by the producer.", |
@@ -8,6 +8,9 @@ and the versioning aims to respect [Semantic Versioning](http://semver.org/spec/ | |||
### Added | |||
- conceptual model (#1976) | |||
|
|||
### Changed | |||
- restructure cost and its subclasses (#1999) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend to just mention the classnames that were changed, in this case maybe cost and the first level of children. The classes were not actually restructured but just moved. However, we usually don't mention, what we did (which can be found in the term trackers).
There is one axiom of social cost which can be deleted without discussion, which is the one to the obsolete class 'economic value'. Seems like we missed to remove it once we made the relation obsolete... |
Good catch @madbkr |
That is a tricky one, but I can imagine this will happen to any other quantity values that are directly converted to process attributes, at least those with the has unit axiom. |
We discussed in #1875 which former |
And the corresponding quantity value would be |
Summary of the discussion
See #1914
Type of change (CHANGELOG.md)
Update
cost
(and all its subclasses) subclass ofprocess attribute
Workflow checklist
Automation
Closes #1914
PR-Assignee
term tracker annotation
Reviewer