Fixes not accepting colon spam with goto labels, adds support for paren-less sleep calls #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't entirely trust this pattern, nor can I really commend its beauty, but we are in desperate need of a method to defer things throughout DMParser. Many functions have clunky syntax or erratic behaviour as a result of not always doing a task on all possible control paths. I've seen a couple TODOs about it as well so, here ya go.
"sleep 40" is now a valid DM statement. sleep, like del, has a special snowflake behaviour that allows it to be called without parentheses when acting as a lone expression-as-statement. "sleep" however isn't precisely a keyword, at least not in OD, so this is adds a bit of snowflake flow control to interpret it correctly anyways.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
BYOND labels no longer allow multiple |
|
Closing in favor of #1461 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #518.
Summary
In this PR is also a little new tool for the codebase: A defer pattern I found for C#. Here, it is used to consume whitespace regardless of which control flow in
ProcStatementFromExpressiondoes the returning. I figure it will be useful in many other places in the codebase later on.Changelog
::::LIKE_THIS::::, are now parsed correctly.sleep 40) is now properly implemented.sleepnow compiletimes, as per parity.