Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bunch of random OpenDreamRuntime warnings #2136

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ike709
Copy link
Collaborator

@ike709 ike709 commented Dec 10, 2024

Gets the runtime below 100 warnings.

@boring-cyborg boring-cyborg bot added the Runtime Involves the OpenDream server/runtime label Dec 10, 2024
@@ -7,6 +7,7 @@

[Virtual]
public class DreamObjectMovable : DreamObjectAtom {
[Dependency] private readonly SharedMapSystem _mapSystem = default!;

Check notice

Code scanning / InspectCode

Prefer using concrete value over 'default' or 'new()' Note

Use 'null' instead of 'default'
OpenDreamRuntime/Procs/NativeProc.cs Fixed Show fixed Hide fixed
@ike709 ike709 marked this pull request as draft December 11, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Runtime Involves the OpenDream server/runtime size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant