New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix off-by-one in peephole optimizer #2131

Merged

wixoaGit merged 1 commit into OpenDreamProject:master from ike709:morefold

Dec 10, 2024

Collaborator

ike709 commented Dec 10, 2024

Fixes #2130

The Math.Max() didn't account for i++ so i could never actually be 0 after the first iteration of the for() loop.

tl;dr off-by-one error


          Fix off-by-one in peephole optimizer

10a9f29

boring-cyborg bot added the Compiler label

github-actions bot added the size/XS label

wixoaGit approved these changes

View reviewed changes

wixoaGit merged commit ac33d86 into OpenDreamProject:master

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Compiler size/XS