Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile error when outputting to const vars in for() loops #2124

Merged
merged 5 commits into from
Dec 9, 2024

Conversation

ike709
Copy link
Collaborator

@ike709 ike709 commented Dec 7, 2024

See included unit test for the issue this PR fixes. Previously, we only runtime errored whereas BYOND compiletime errored.

@boring-cyborg boring-cyborg bot added the Compiler Involves the OpenDream compiler label Dec 7, 2024
DMCompiler/DM/Builders/DMProcBuilder.cs Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/M and removed size/XS labels Dec 8, 2024
@ike709 ike709 requested a review from wixoaGit December 8, 2024 15:41
DMCompiler/DM/Builders/DMProcBuilder.cs Fixed Show resolved Hide resolved
DMCompiler/DM/Builders/DMProcBuilder.cs Fixed Show resolved Hide resolved
DMCompiler/DM/Builders/DMProcBuilder.cs Outdated Show resolved Hide resolved
@wixoaGit wixoaGit enabled auto-merge (squash) December 9, 2024 03:38
@wixoaGit wixoaGit merged commit 54bd243 into OpenDreamProject:master Dec 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compiler Involves the OpenDream compiler size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants