Compiletime rgb() evaluation
#2115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
Client
ike709
changed the title
rgb() evaluationrgb() evaluation
ike709
commented
Nov 30, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| // TODO: There is a difference between passing null and not passing a fourth arg at all | ||
| if (a is null) { |
Check notice
Code scanning / InspectCode
'if' statement can be rewritten as '?:' expression Note
There was a problem hiding this comment.
The huge ternary is less readable, so no.
There was a problem hiding this comment.
Yea I think this is a notice we should turn off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rgb()is supposed to be considered a constant when its args are constant, as shown in the included unit test which passes in BYOND.To facilitate this,
rgb()handling has been moved to the compiler and theDMExpressionnow implementsTryAsConstant().As a bonus, the peephole optimizer will attempt to evaluate it at compiletime whenever
Rgb's argtype isFromStackand its argcount matches a precedingPushNFloatscount. That means we'll compiletime eval something likergb(255,255,255)but notrgb(255,255,255, space=foo()).