Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bad proc param test #2113

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

ike709
Copy link
Collaborator

@ike709 ike709 commented Nov 29, 2024

Another Broken Test test that didn't actually work in BYOND. Also changed the obj to a datum for no particular reason.

Original:
image

This PR:
image

Copy link
Contributor

@amylizzle amylizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh I swear byond used to do some fuckery if you passed null as an arg name

@ike709
Copy link
Collaborator Author

ike709 commented Dec 4, 2024

Not in this context. That involves shenanigans with proc overrides, like I told you on discord the other day.

@wixoaGit
Copy link
Member

Not in this context. That involves shenanigans with proc overrides, like I told you on discord the other day.

I'm fairly sure using null as the name of an argument in any context would have that become the new null. This was probably fixed in newer versions of BYOND.

@wixoaGit wixoaGit merged commit 2e5ad95 into OpenDreamProject:master Dec 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants