Experimental screen edge loc implementation #2111
Conversation
boring-cyborg
bot
added
Client
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Vector2 iconSize = sprite.Icon.DMI == null ? Vector2.Zero : sprite.Icon.DMI.IconSize / (float)EyeManager.PixelsPerMeter; | ||
| Interface.Descriptors.ControlDescriptorMap mapDescriptor = (Interface.Descriptors.ControlDescriptorMap) _interfaceManager.DefaultMap.ElementDescriptor; |
Check warning
Code scanning / InspectCode
Dereference of a possibly null reference. Warning
| Vector2 iconSize = sprite.Icon.DMI == null ? Vector2.Zero : sprite.Icon.DMI.IconSize / (float)EyeManager.PixelsPerMeter; | ||
| Interface.Descriptors.ControlDescriptorMap mapDescriptor = (Interface.Descriptors.ControlDescriptorMap) _interfaceManager.DefaultMap.ElementDescriptor; | ||
| var viewport = _interfaceManager.DefaultMap.Viewport; | ||
| float mapZoom = mapDescriptor.IconSize.Value != 0 ? EyeManager.PixelsPerMeter / (float) mapDescriptor.IconSize.Value : 1; |
Check warning
Code scanning / InspectCode
Redundant cast Warning
| float mapZoom = mapDescriptor.IconSize.Value != 0 ? EyeManager.PixelsPerMeter / (float) mapDescriptor.IconSize.Value : 1; | ||
| // Limit the viewport drawbox just to what's visible on-screen. | ||
| var drawBox = viewport.GetDrawBox().Intersection(_interfaceManager.DefaultMap.Viewport.GlobalPixelRect.Intersection(_interfaceManager.DefaultMap.UIElement.GlobalPixelRect) ?? UIBox2i.FromDimensions(0, 0, 0, 0)) ?? UIBox2i.FromDimensions(0, 0, 0, 0); | ||
| Vector2 viewportTileSize = Vector2.Min(drawBox.Size, viewport.Size) * mapZoom / (float)EyeManager.PixelsPerMeter; |
Check warning
Code scanning / InspectCode
Redundant cast Warning
| @@ -6,19 +6,24 @@ | |||
| using System.Linq; | |||
| using System.Text; | |||
| using Robust.Shared.Log; | |||
| using Robust.Shared.Maths; | |||
Check warning
Code scanning / InspectCode
Redundant using directive Warning
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
I have no plans to continue this, this is just for reference purposes so wixoa can see my code and compare it to #2106.