Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code hot reloading #2101

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

amylizzle
Copy link
Contributor

@amylizzle amylizzle commented Nov 18, 2024

Allows the vscode extension to trigger recompile and reload object and proc defs

OpenDreamProject/vscode-opendream#20

@boring-cyborg boring-cyborg bot added the Runtime Involves the OpenDream server/runtime label Nov 18, 2024

_compiledJson = json;
var rootPath = Path.GetFullPath(Path.GetDirectoryName(jsonPath)!);
var resources = _compiledJson.Resources ?? Array.Empty<string>();

Check notice

Code scanning / InspectCode

Use collection expression syntax Note

Use collection expression
_objectTree.LoadJson(json);
DreamProcNative.SetupNativeProcs(_objectTree);

}

Check warning

Code scanning / InspectCode

Incorrect blank lines: Incorrect number of blank lines near braces Warning

Incorrect number of blank lines near braces, expected maximum 0 instead of 1
requestHotReloadBytecode.RespondError(client, "No file provided for a hot reload");
return;
}
_sawmill.Debug($"Debug adapter triggered bytecode hot reload for file {requestHotReloadBytecode.Arguments.FilePath}");

Check warning

Code scanning / InspectCode

Incorrect blank lines: Blank lines are missing elsewhere Warning

Blank lines are missing, expected minimum 1 instead of 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Runtime Involves the OpenDream server/runtime size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant