Freeze some collections for faster accessing #2023
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -454,14 +470,14 @@ | |||
|
|
|||
| internal void SetGlobalNativeProc(NativeProc.HandlerFn func) { | |||
| var (name, defaultArgumentValues, argumentNames) = NativeProc.GetNativeInfo(func); | |||
| var proc = new NativeProc(_globalProcIds[name], Root, name, argumentNames, defaultArgumentValues, func, _dreamManager, _atomManager, _dreamMapManager, _dreamResourceManager, _walkManager, this); | |||
| var proc = new NativeProc(_globalProcIds![name], Root, name, argumentNames, defaultArgumentValues, func, _dreamManager, _atomManager, _dreamMapManager, _dreamResourceManager, _walkManager, this); | |||
Check warning
Code scanning / InspectCode
Redundant nullable warning suppression expression Warning
| @@ -454,14 +470,14 @@ | |||
|
|
|||
| internal void SetGlobalNativeProc(NativeProc.HandlerFn func) { | |||
| var (name, defaultArgumentValues, argumentNames) = NativeProc.GetNativeInfo(func); | |||
| var proc = new NativeProc(_globalProcIds[name], Root, name, argumentNames, defaultArgumentValues, func, _dreamManager, _atomManager, _dreamMapManager, _dreamResourceManager, _walkManager, this); | |||
| var proc = new NativeProc(_globalProcIds![name], Root, name, argumentNames, defaultArgumentValues, func, _dreamManager, _atomManager, _dreamMapManager, _dreamResourceManager, _walkManager, this); | |||
Check warning
Code scanning / InspectCode
Possible null reference argument for a parameter. Warning
|
|
||
| Procs[proc.Id] = proc; | ||
| } | ||
|
|
||
| public void SetGlobalNativeProc(Func<AsyncNativeProc.State, Task<DreamValue>> func) { | ||
| var (name, defaultArgumentValues, argumentNames) = NativeProc.GetNativeInfo(func); | ||
| var proc = new AsyncNativeProc(_globalProcIds[name], Root, name, argumentNames, defaultArgumentValues, func); | ||
| var proc = new AsyncNativeProc(_globalProcIds![name], Root, name, argumentNames, defaultArgumentValues, func); |
Check warning
Code scanning / InspectCode
Redundant nullable warning suppression expression Warning
|
|
||
| Procs[proc.Id] = proc; | ||
| } | ||
|
|
||
| public void SetGlobalNativeProc(Func<AsyncNativeProc.State, Task<DreamValue>> func) { | ||
| var (name, defaultArgumentValues, argumentNames) = NativeProc.GetNativeInfo(func); | ||
| var proc = new AsyncNativeProc(_globalProcIds[name], Root, name, argumentNames, defaultArgumentValues, func); | ||
| var proc = new AsyncNativeProc(_globalProcIds![name], Root, name, argumentNames, defaultArgumentValues, func); |
Check warning
Code scanning / InspectCode
Possible null reference argument for a parameter. Warning
|
Superseded by #2031 |
Converts some collections on
DreamObjectTreeandDreamObjectDefinitionto their frozen variants. On my machine this consistently reduced Paradise round init by roughly ~2 seconds. I only compared third and fourth runs for both before & after so PGO wouldn't impact the results.Since these collections never change after JSON parsing, it's a free performance boost on any accesses for the remainder of the round.
I'll try to tackle Procs & Variables in a subsequent PR since they need a bit more wrangling.