Implement as syntax for multiple base types (mob|obj|turf)
#1917
Conversation
boring-cyborg
bot
added
Compiler
|
This is probably not a great first project (it was supposedly easy at first, but the proper implementation is slightly more complicated) for me, so the code quality is dubious. Current issues are something along the lines of |
…ssary second bytecase and a unnecessary null check, though. Also add annotated bytecode case
|
It compiles without errors so I'm undrafting this and re-requesting review |
| // "as anything" performs no check. Other than that, all that's left are type assignments like `as mob|obj|area`. | ||
| proc.CreateFilteredBaseTypesListEnumerator((byte) dmTypes.Value.Type, dmTypes.Value.Type); | ||
| alreadyCreatedEnumerator = true; | ||
| DMCompiler.VerbosePrint($"Created CreateFilteredBaseTypesListEnumerator"); |
There was a problem hiding this comment.
do we want this print here?
|
|
||
| public DreamPath[] GetDMAncestors() { | ||
|
|
||
| } |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Abandoned? |
|
Yeah these haven't been worked on for a while, I'm not sure if I'll be able to get to them. Someone else can continue it or work on it if they want |
This is an attempt to support code like
to continue the implementation parity between OD and DM