Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appearance Weakrefs #1815

Open
wants to merge 78 commits into
base: master
Choose a base branch
from

Merge branch 'master' into appearanceRefCounts

b8ea258
Select commit
Loading
Failed to load commit list.
Open

Appearance Weakrefs #1815

Merge branch 'master' into appearanceRefCounts
b8ea258
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / InspectCode succeeded Dec 4, 2024 in 7s

37 new alerts

New alerts in code changed by this pull request

  • 27 warnings
  • 10 notes

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 47 in OpenDreamClient/Rendering/DreamIcon.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are missing elsewhere Warning

Blank lines are missing, expected minimum 1 instead of 0

Check warning on line 561 in OpenDreamClient/Rendering/DreamIcon.cs

See this annotation in the file changed.

Code scanning / InspectCode

Struct with default equality members is used for comparison: Private accessibility Warning

Struct 'AppearanceAnimation' is checked for equality using the inefficient runtime-provided implementation

Check notice on line 495 in OpenDreamRuntime/AtomManager.cs

See this annotation in the file changed.

Code scanning / InspectCode

Merge null/pattern checks into complex pattern Note

Merge into pattern

Check notice on line 548 in OpenDreamRuntime/AtomManager.cs

See this annotation in the file changed.

Code scanning / InspectCode

Merge null/pattern checks into complex pattern Note

Merge into pattern

Check warning on line 555 in OpenDreamRuntime/AtomManager.cs

See this annotation in the file changed.

Code scanning / InspectCode

Unused local variable Warning

Local variable 'area' is never used

Check warning on line 559 in OpenDreamRuntime/AtomManager.cs

See this annotation in the file changed.

Code scanning / InspectCode

Unused local variable Warning

Local variable 'client' is never used

Check warning on line 562 in OpenDreamRuntime/AtomManager.cs

See this annotation in the file changed.

Code scanning / InspectCode

Unused local variable Warning

Local variable 'filter' is never used

Check warning on line 578 in OpenDreamRuntime/AtomManager.cs

See this annotation in the file changed.

Code scanning / InspectCode

Unused local variable Warning

Local variable 'area' is never used

Check warning on line 194 in OpenDreamRuntime/DreamMapManager.cs

See this annotation in the file changed.

Code scanning / InspectCode

Possible unintended reference comparison. To get a value comparison, use 'Equals' method. Warning

Possible unintended reference comparison. To get a value comparison, use 'Equals' method.

Check notice on line 185 in OpenDreamRuntime/Objects/Types/DreamObjectAtom.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect indent: Around statement braces Note

Line indent is not restored to the previous level around statement braces

Check warning on line 180 in OpenDreamRuntime/Procs/Native/DreamProcNativeHelpers.cs

See this annotation in the file changed.

Code scanning / InspectCode

Redundant nullable warning suppression expression Warning

The nullable warning suppression expression is redundant

Check warning on line 11 in OpenDreamRuntime/Rendering/ServerAppearanceSystem.cs

See this annotation in the file changed.

Code scanning / InspectCode

Redundant using directive Warning

Using directive is not required by the code and can be safely removed

Check warning on line 12 in OpenDreamRuntime/Rendering/ServerAppearanceSystem.cs

See this annotation in the file changed.

Code scanning / InspectCode

Redundant using directive Warning

Using directive is not required by the code and can be safely removed

Check warning on line 23 in OpenDreamRuntime/Rendering/ServerAppearanceSystem.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are missing elsewhere Warning

Blank lines are missing, expected minimum 1 instead of 0

Check warning on line 23 in OpenDreamRuntime/Rendering/ServerAppearanceSystem.cs

See this annotation in the file changed.

Code scanning / InspectCode

Inconsistent Naming Warning

Name '_TTLQueue' does not match rule 'Instance fields (private)'. Suggested name is '_ttlQueue'.

Check warning on line 24 in OpenDreamRuntime/Rendering/ServerAppearanceSystem.cs

See this annotation in the file changed.

Code scanning / InspectCode

Inconsistent Naming Warning

Name '_TTLQueueHashtable' does not match rule 'Instance fields (private)'. Suggested name is '_ttlQueueHashtable'.

Check warning on line 25 in OpenDreamRuntime/Rendering/ServerAppearanceSystem.cs

See this annotation in the file changed.

Code scanning / InspectCode

Inconsistent Naming Warning

Name '_TTL' does not match rule 'Instance fields (private)'. Suggested name is '_ttl'.

Check warning on line 28 in OpenDreamRuntime/Rendering/ServerAppearanceSystem.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are redundant elsewhere Warning

Blank lines are redundant, expected maximum 1 instead of 2

Check warning on line 92 in OpenDreamRuntime/Rendering/ServerAppearanceSystem.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are missing elsewhere Warning

Blank lines are missing, expected minimum 1 instead of 0

Check notice on line 142 in OpenDreamRuntime/Rendering/ServerAppearanceSystem.cs

See this annotation in the file changed.

Code scanning / InspectCode

Use explicit or implicit modifier definition for types Note

Inconsistent modifiers style: missing 'internal' modifier

Check notice on line 146 in OpenDreamRuntime/Rendering/ServerAppearanceSystem.cs

See this annotation in the file changed.

Code scanning / InspectCode

Convert constructor into primary constructor Note

Convert into primary constructor

Check warning on line 143 in OpenDreamShared/Dream/ImmutableIconAppearance.cs

See this annotation in the file changed.

Code scanning / InspectCode

Equality comparison of floating point numbers. Possible loss of precision while rounding values Warning

Equality comparison of floating point numbers. Possible loss of precision while rounding values

Check warning on line 144 in OpenDreamShared/Dream/ImmutableIconAppearance.cs

See this annotation in the file changed.

Code scanning / InspectCode

Possibly impure struct method is called on readonly variable: struct value always copied before invocation Warning

Possibly impure struct method called on readonly variable: struct value always copied before invocation

Check warning on line 145 in OpenDreamShared/Dream/ImmutableIconAppearance.cs

See this annotation in the file changed.

Code scanning / InspectCode

Equality comparison of floating point numbers. Possible loss of precision while rounding values Warning

Equality comparison of floating point numbers. Possible loss of precision while rounding values

Check warning on line 189 in OpenDreamShared/Dream/ImmutableIconAppearance.cs

See this annotation in the file changed.

Code scanning / InspectCode

Non-readonly type member referenced in 'GetHashCode()' Warning

Non-readonly field referenced in 'GetHashCode()'