Move some math operations to SharedOperations
#1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As well as error improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a
SharedOperationsclass and moved some math operations to it. This class is meant for operations done by both the compiler and the server, to ensure they give the same results on both.I also replaced the
CompileErrorExceptions used by these math operations with compiler emissions. There's now aFallbackBuiltinArgumentemission that defaults to a warning and tells you when an invalid argument is falling back to another value:/obj/var/foo = cos("invalid")Warning OD2208 at ...: Invalid value treated as 0, cos(0) will always be 1