Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a for loop in DreamList.ContainsValue() #1470

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

wixoaGit
Copy link
Member

@wixoaGit wixoaGit commented Sep 15, 2023

C#'s list Contains() method usies a GenericEqualityComparer which allocates. This removes ~600MB total allocations during BeeStation init bringing it down to 7.3GB.

@wixoaGit wixoaGit merged commit 6f9755f into OpenDreamProject:master Sep 15, 2023
4 checks passed
@wixoaGit wixoaGit deleted the reduce_list_alloc branch September 15, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant