Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes findtextlast() and adds test #1451

Merged
merged 3 commits into from
Sep 17, 2023
Merged

Fixes findtextlast() and adds test #1451

merged 3 commits into from
Sep 17, 2023

Conversation

amylizzle
Copy link
Contributor

fixes #1444

This was a huge pain in the ass to figure out.

wixoaGit
wixoaGit reviewed Sep 15, 2023
View reviewed changes
Copy link
Member

@wixoaGit wixoaGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default values for Start/End also need to be fixed for findlasttextEx()

@amylizzle amylizzle requested a review from wixoaGit September 17, 2023 10:19
@wixoaGit wixoaGit merged commit 0fb43f6 into OpenDreamProject:master Sep 17, 2023
4 checks passed
@amylizzle amylizzle deleted the findlasttext branch September 17, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wixoaGit wixoaGit wixoaGit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

findtextlast() doesn't work with negative indices
2 participants
@amylizzle @wixoaGit