Implement on-show and on-hide for map controls, plus winset parsing fixes
#1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
46 tasks
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
wixoaGit
requested changes
Oct 13, 2023
wixoaGit
requested changes
Oct 14, 2023
wixoaGit
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
on-showandon-hidewinset calls for the map control.Fixes nested attribute parsing in winset, ie
thing.stuff.var=value(previously we could only dothing.stuff=valueand deeper references would fail to parse silently).Slight buff to the robustness of winset parsing also, as it's no longer fragile about whitespace. Previously it would break if there was no space between
.winsetand the command.Also refactors the DreamCommandSystem so all verbs run through the DreamInterfaceManager now