Implement initial() for arglist() (#2123)

Co-authored-by: ike709 <[email protected]>
OpenDreamProject · Dec 8, 2024 · 8a7abfc · 8a7abfc
1 parent 939512d
commit 8a7abfc
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/Content.Tests/DMProject/Broken Tests/Procs/Arglist/initial.dm b/Content.Tests/DMProject/Broken Tests/Procs/Arglist/initial.dm
diff --git a/Content.Tests/DMProject/Tests/Procs/Arglist/initial.dm b/Content.Tests/DMProject/Tests/Procs/Arglist/initial.dm
@@ -0,0 +1,6 @@
+
+/proc/_initial(...)
+	ASSERT(initial(arglist(args))[1] == "foo")
+
+/proc/RunTest()
+	_initial("foo")
diff --git a/DMCompiler/DM/Expressions/Builtins.cs b/DMCompiler/DM/Expressions/Builtins.cs
@@ -505,6 +505,13 @@ public override void EmitPushValue(ExpressionContext ctx) {
             return;
         }
 
+        if (Expression is Arglist arglist) {
+            // This happens silently in BYOND
+            ctx.Compiler.Emit(WarningCode.PointlessBuiltinCall, Location, "calling initial() on arglist() returns the current value");
+            arglist.EmitPushArglist(ctx);
+            return;
+        }
+
         ctx.Compiler.Emit(WarningCode.BadArgument, Expression.Location, $"can't get initial value of {Expression}");
         ctx.Proc.Error();
     }