Fix stringifying infinity (#2112)

Co-authored-by: ike709 <[email protected]>
OpenDreamProject · Dec 1, 2024 · 610688c · 610688c
1 parent b9bfd6a
commit 610688c
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 9 deletions.
diff --git a/Content.Tests/DMProject/Broken Tests/Expression/Constants/numeral_inf.dm b/Content.Tests/DMProject/Broken Tests/Expression/Constants/numeral_inf.dm
diff --git a/Content.Tests/DMProject/Tests/Expression/Constants/stringify_inf.dm b/Content.Tests/DMProject/Tests/Expression/Constants/stringify_inf.dm
@@ -0,0 +1,8 @@
+
+/proc/RunTest()
+	var/a = 1#INF
+	var/b = -1#INF
+	var/c = -1#IND
+	ASSERT("[a]" == "inf")
+	ASSERT("[b]" == "-inf")
+	ASSERT("[c]" == "nan")
diff --git a/OpenDreamRuntime/DreamValue.cs b/OpenDreamRuntime/DreamValue.cs
@@ -362,6 +362,11 @@ public string Stringify() {
             case DreamValueType.Float:
                 var floatValue = MustGetValueAsFloat();
 
+                if (float.IsInfinity(floatValue)) {
+                    var str = float.IsPositiveInfinity(floatValue) ? "inf" : "-inf";
+                    return str;
+                }
+
                 if (floatValue > 16777216f) {
                     return floatValue.ToString("g6");
                 }
@@ -371,6 +376,8 @@ public string Stringify() {
                     return floatValue.ToString("g8");
                 }
 
+                if (float.IsNaN(floatValue)) return "nan";
+
                 return floatValue.ToString("g6");
 
             case DreamValueType.DreamResource: