Skip to content

Commit

Permalink
fix client image bugs
Browse files Browse the repository at this point in the history
  • Loading branch information
amylizzle committed Nov 11, 2024
1 parent c63f765 commit 2a11400
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
5 changes: 3 additions & 2 deletions OpenDreamClient/Rendering/DreamViewOverlay.cs
Original file line number Diff line number Diff line change
Expand Up @@ -316,9 +316,10 @@ private void ProcessIconComponents(DreamIcon icon, Vector2 position, EntityUid u
continue;
if(sprite.Icon.Appearance == null)
continue;
if(sprite.Icon.Appearance.Override)
if(sprite.Icon.Appearance.Override) {
current.MainIcon = sprite.Icon;
else
current.Position = current.Position + (sprite.Icon.Appearance.TotalPixelOffset / (float)EyeManager.PixelsPerMeter);
} else
ProcessIconComponents(sprite.Icon, current.Position, uid, isScreen, ref tieBreaker, result, current);
}
}
Expand Down
1 change: 1 addition & 0 deletions OpenDreamShared/Dream/ImmutableIconAppearance.cs
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ public override int GetHashCode() {
hashCode.Add(Layer);
hashCode.Add(Invisibility);
hashCode.Add(Opacity);
hashCode.Add(Override);
hashCode.Add(MouseOpacity);
hashCode.Add(Alpha);
hashCode.Add(GlideSize);
Expand Down
1 change: 1 addition & 0 deletions OpenDreamShared/Dream/MutableIconAppearance.cs
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ public override int GetHashCode() {
hashCode.Add(Layer);
hashCode.Add(Invisibility);
hashCode.Add(Opacity);
hashCode.Add(Override);

Check warning

Code scanning / InspectCode

Non-readonly type member referenced in 'GetHashCode()' Warning

Non-readonly field referenced in 'GetHashCode()'
hashCode.Add(MouseOpacity);
hashCode.Add(Alpha);
hashCode.Add(GlideSize);
Expand Down

0 comments on commit 2a11400

Please sign in to comment.