Put more data into the error JSON returned, when grouping validation errors #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow individual project libraries (e.g. lib-cove-bods) to rewrite their own error messages more easily.
Bjwebb
force-pushed
the
cove-bods-16-return-more-validation-info
branch
from
35d7c2f
to
62a8f0f
Compare
odscjames
approved these changes
Apr 2, 2019
|
Will this have effects for other standards? It would be good to have a serious chat about how you see the split of CoVE libraries, and if there is anything we can do to make the interfaces across them cleaner. |
|
This shouldn't affect other standards. Our cove tests are reasonably specific about validation messages, and those still all pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow different CoVEs to write their own validation messages. We want this for BODS first of all.
Context: openownership/cove-bods#16 (comment)