First attempt to update for 21w20a #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you run gradlew check? |
|
Yes, sorry for the delay, but ./gradlew check works without any issues reported. |
|
Ok so for some darn reason, whenever I pull your branch, it doesnt let me build gradle bc of either a bad loom version or the wrong gradle version. But your diff shows you didnt touch gradle wrapper's properties or build.gradle itself. |
CorgiTaco
added
1.17
Blocker/Critical
Compatibility
and removed
Blocker/Critical
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a naïve but functional attempt to add support for the new 21w20a calling conventions to MC_1.17. Please feel free to change anything / let me know if you'd like to see implementation for ChunkStatus rather than just stubs, however this does compile and appear to work as well as it did on 21w19a.