Add the CSP headers if they are set as an env variable at startup #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quartje
reviewed
Nov 2, 2023
|
@quartje - please test :) |
|
@quartje - took the opportunity in this PR and I also fixed the logging, to make sure the logs go to stdout. The issue was that even if I configured the default log destination to be stdout and stderr, In the virtual host config the destination was still the log file. I had to overwrite the default vhost config as well to make sure we log to stdout. Please test this as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@quartje - I have tested this with the following command:
docker run -p 8080:80 -e HTTPD_CSP="default-src; object-src 'none'; script-src 'self' 'unsafe-inline'; style-src 'self' 'unsafe-inline'; font-src 'self'; connect-src 'self'; img-src 'self' data:; form-action 'self'; base-uri 'none'" apache2:testand it works, it adds the line to the config.I think this is similar to what Ansible will add.