Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes #173

Merged
merged 4 commits into from
Mar 31, 2020
Merged

Various fixes #173

merged 4 commits into from
Mar 31, 2020

Conversation

alesgenova
Copy link
Member

@alesgenova alesgenova commented Mar 27, 2020

Depends on the following external PR:
OpenChemistry/mongochemserver#186
OpenChemistry/oc-web-components#160

Fixes: #169
Fixes: #170
Fixes: #172 (Didn't try to fix it directly, might be a side effect)

@alesgenova alesgenova requested review from cryos and cjh1 March 27, 2020 20:43
@cryos
Copy link
Member

cryos commented Mar 31, 2020

These all look reasonable to me.

@alesgenova alesgenova marked this pull request as ready for review March 31, 2020 16:14
@cjh1 cjh1 merged commit 360edd2 into master Mar 31, 2020
@cjh1 cjh1 deleted the various-fixes branch March 31, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants