pin pydantic to v1.10.10 everywhere #873
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is because of release of pydantic 2.0, we should migrate. |
- base cannot be built, librocksdb problem again. Tried many ways, nothing works... - obviously we shouldnt leave this like this...
new behavior adds trailing `/` to end of links without a path: pydantic/pydantic#7186 (comment)
unsure if this is expected, or because TZ is not set...
swelborn
force-pushed
the
pin-pydantic
branch
from
66063f3
to
9e1588e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent version of pydantic takes BaseSettings to a different package:
https://docs.pydantic.dev/latest/concepts/pydantic_settings/
This was an issue for me when I installed pydantic recently for the watcher cli. It will probably cause issues with other sections of the code, so I pinned it everywhere after searching the repo for
pydantic[dotenv]. It was already pinned in the microservices base image.